Implement proper timers for the index/sync command #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As stated in this comment, the times displayed by the WP-CLI sync/index command are currently wrong. That is happening because the code relies on WP's timer_start() but that does not work with nested calls: as Indexable is also calling that function, the timer resets for every batch of documents.
The PR introduces a timer_* collection of functions, inspired a bit by what WP core has in its wpdb class.
Changelog Entry
Fixed: "Time elapsed" and "Total time elapsed" in WP-CLI
indexcommand.Credits
Props @felipeelia @archon810